Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): update recommended sets #2001

Merged
merged 1 commit into from May 10, 2020
Merged

Conversation

bradzacher
Copy link
Member

BREAKING CHANGE:

Fixes #1423

@bradzacher bradzacher added breaking change This change will require a new major version to be released recommended-rules Discussion about recommended rule sets labels May 10, 2020
@bradzacher bradzacher added this to the 3.0.0 milestone May 10, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher linked an issue May 10, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #2001 into v3 will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##               v3    #2001   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files         172      176    +4     
  Lines        7813     7817    +4     
  Branches     2245     2245           
=======================================
+ Hits         7324     7328    +4     
  Misses        228      228           
  Partials      261      261           
Flag Coverage Δ
#unittest 93.74% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/ban-ts-ignore.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/camelcase.ts 92.85% <ø> (ø)
...kages/eslint-plugin/src/rules/class-name-casing.ts 100.00% <ø> (ø)
...int-plugin/src/rules/consistent-type-assertions.ts 86.48% <ø> (ø)
...-plugin/src/rules/explicit-function-return-type.ts 100.00% <ø> (ø)
...plugin/src/rules/explicit-module-boundary-types.ts 82.60% <ø> (ø)
...s/eslint-plugin/src/rules/interface-name-prefix.ts 100.00% <ø> (ø)
.../eslint-plugin/src/rules/member-delimiter-style.ts 94.44% <ø> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 88.51% <ø> (ø)
... and 25 more

@bradzacher bradzacher merged commit 3947418 into v3 May 10, 2020
@bradzacher bradzacher deleted the v3-recommended-sets branch May 10, 2020 19:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released recommended-rules Discussion about recommended rule sets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to the recommended sets for 3.0.0
1 participant