feat(eslint-plugin): [no-floating-promises] ignore void operator by default #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradzacher
added
enhancement
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
bradzacher
force-pushed
the
v3-no-floating-promise
branch
from
5dbc169
to
98badd6
Compare
Codecov Report
@@ Coverage Diff @@
## v3 #2003 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 176 176
Lines 7814 7814
Branches 2240 2240
=======================================
Hits 7326 7326
Misses 228 228
Partials 260 260
|
bradzacher
changed the title
bradzacher
added a commit
that referenced
this pull request
May 11, 2020
bradzacher
added a commit
that referenced
this pull request
May 14, 2020
bradzacher
added a commit
that referenced
this pull request
May 17, 2020
bradzacher
added a commit
that referenced
this pull request
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint/eslint#12613 was released in eslint v7, so it's now possible and easy to use this within the ecosystem.
I think this makes sense as a way to consume top-level promises, so changing it to
true.