Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@typescript-eslint/eslint-plugin-tslint update peerDependency to support recently released eslint@7.0.0 #2016

Closed
nickharris opened this issue May 12, 2020 · 1 comment
Labels
package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for maintainers to take a look

Comments

@nickharris
Copy link

Repro
eslint 7 was recently released https://www.npmjs.com/package/eslint/v/7.0.0 you take a peer dependency on 5 and 6 only.

  1. update to the new eslint@7.0.0 npm install --save eslint@7.0.0
  2. npm install @typescript-eslint/eslint-plugin-tslint@2.32.0
  3. Get error > npm WARN @typescript-eslint/eslint-plugin-tslint@2.32.0 requires a peer of eslint@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.

looks like package.json peerDepenencies needs to be updated to add || ^7.0.0 for eslint.

Expected Result
no warning on install
Actual Result
npm WARN @typescript-eslint/eslint-plugin-tslint@2.32.0 requires a peer of eslint@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.

Additional Info
looks like package.json peerDepenencies needs to be updated to add || ^7.0.0 for newly released eslint 7 https://www.npmjs.com/package/eslint/v/7.0.0

Versions

package version
@typescript-eslint/eslint-plugin-tslint ^2.32.0
@typescript-eslint/parser ^2.32.0
TypeScript 3.5.3
ESLint 7.0.0
node 12.13.0
npm 6.13.6
@nickharris nickharris added package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for maintainers to take a look labels May 12, 2020
@nickharris nickharris changed the title support peerDependency eslint 7 update peerDependency to support recently released eslint@7.0.0 May 12, 2020
@nickharris nickharris changed the title update peerDependency to support recently released eslint@7.0.0 @typescript-eslint/eslint-plugin-tslint update peerDependency to support recently released eslint@7.0.0 May 12, 2020
@bradzacher
Copy link
Member

See #1550

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for maintainers to take a look
Projects
None yet
Development

No branches or pull requests

2 participants