Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to ESLint v7 #2022

Merged
merged 13 commits into from May 14, 2020
Merged

feat: upgrade to ESLint v7 #2022

merged 13 commits into from May 14, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented May 14, 2020

Lots of broken tests, a few copied enhancements, otherwise not that bad.
Didn't realise we hadn't updated the integration test image in a while.. it was still on node 8!

Fixes #1550

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label May 14, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #2022 into v3 will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##               v3    #2022      +/-   ##
==========================================
- Coverage   93.64%   93.61%   -0.03%     
==========================================
  Files         169      169              
  Lines        7677     7680       +3     
  Branches     2193     2195       +2     
==========================================
+ Hits         7189     7190       +1     
- Misses        229      231       +2     
  Partials      259      259              
Flag Coverage Δ
#unittest 93.61% <33.33%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <ø> (ø)
...kages/eslint-plugin/src/rules/func-call-spacing.ts 96.87% <ø> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts 88.46% <ø> (ø)
...nt-plugin/src/rules/space-before-function-paren.ts 100.00% <ø> (ø)
.../experimental-utils/src/eslint-utils/RuleTester.ts 9.75% <0.00%> (-0.51%) ⬇️
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.87% <100.00%> (+0.04%) ⬆️

@bradzacher bradzacher merged commit d3357b2 into v3 May 14, 2020
@bradzacher bradzacher deleted the v3-eslint-v7 branch May 14, 2020 04:31
bradzacher added a commit that referenced this pull request May 14, 2020
bradzacher added a commit that referenced this pull request May 17, 2020
bradzacher added a commit that referenced this pull request May 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant