feat(experimental-utils): upgrade eslint types for v7 #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: - Renames some interfaces to be closer to the underlying ESLint definitions. - Changes the definitions to use `declare class` instead of interface types so they're a little more sane. - Marks a lot of properties as readonly - some because it's correct (eg context and source code) - some because it makes some things easier - Removed types for APIs that have been deprecated. - Some had been deprecated for 3 major versions - it's time to move on. - Removed deprecated parser options. Added a lot of jsdoc to the types. Like a lot. Some taken from eslint's site, some taken from the source code.
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## v3 #2023 +/- ##
==========================================
- Coverage 93.61% 93.61% -0.01%
==========================================
Files 169 170 +1
Lines 7680 7679 -1
Branches 2195 2193 -2
==========================================
- Hits 7190 7189 -1
Misses 231 231
Partials 259 259
|
bradzacher
added a commit
that referenced
this pull request
May 14, 2020
bradzacher
added a commit
that referenced
this pull request
May 17, 2020
bradzacher
added a commit
that referenced
this pull request
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
declare classinstead of interface types so they're a little more sane.Added a lot of jsdoc to the types. Like a lot. Some taken from eslint's site, some taken from the source code.