fix(typescript-estree): fix handling of range/loc removal

[captainblue2013]

if I pass the options with
{
comment: true,
loc: false,
range: false,
}

when parsing, I expect it should remove loc & range both

[typescript-eslint]

Thanks for the PR, @captainblue2013!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #2028 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2028   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files         172      172           
  Lines        7829     7829           
  Branches     2245     2245           
=======================================
  Hits         7354     7354           
  Misses        217      217           
  Partials      258      258           

Flag	Coverage Δ
#unittest	93.93% <100.00%> (ø)

Impacted Files	Coverage Δ
packages/typescript-estree/src/ast-converter.ts	100.00% <100.00%> (ø)

[bradzacher]

thanks!

[JounQin]

@bradzacher This seems to be incompatible with espree and babel-eslint which include loc and range by default. What means should we check if the value is false specifically instead of removing them by default.

I'm developing an eslint plugin which support babel-eslint and @typescript-eslint/typesript-estree at the same time. But I found it broke some cases in recent days, and it wasted me a few hours to find out why loc and range were missing...

[bradzacher]

typescript-estree has a its options and defaults spelled out:
https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/typescript-estree#parsecode-options

typescript-eslint/packages/typescript-estree/README.md

Lines 114 to 129 in ee9f100

	const PARSE_DEFAULT_OPTIONS: ParseOptions = {
	comment: false,
	errorOnUnknownASTType: false,
	filePath: 'estree.ts', // or 'estree.tsx', if you pass jsx: true
	jsx: false,
	loc: false,
	loggerFn: undefined,
	range: false,
	tokens: false,
	useJSXTextNode: false,
	};
	declare function parse(
	code: string,
	options: ParseOptions = PARSE_DEFAULT_OPTIONS,
	): TSESTree.Program;

The system was working incorrectly before this PR. It was always supposed to treat ast and loc as false by default.

[captainblue2013]

@JounQin Sorry about that