Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): add suggestion property for rule modules #2033

Merged
merged 3 commits into from May 17, 2020
Merged

feat(experimental-utils): add suggestion property for rule modules #2033

merged 3 commits into from May 17, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 16, 2020

This property doesn't seem to be used for anything by ESLint (suggestions still work without it), but it's in the docs, and would let us plugin devs check if our rules have suggestions for documentation generation tooling.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #2033 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2033   +/-   ##
=======================================
  Coverage   93.93%   93.93%           
=======================================
  Files         172      172           
  Lines        7829     7829           
  Branches     2245     2245           
=======================================
  Hits         7354     7354           
  Misses        217      217           
  Partials      258      258           
Flag Coverage Δ
#unittest 93.93% <ø> (ø)
Impacted Files Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <ø> (ø)
...ages/eslint-plugin/src/rules/no-empty-interface.ts 96.15% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 92.85% <ø> (ø)
...es/eslint-plugin/src/rules/no-floating-promises.ts 100.00% <ø> (ø)
...n/src/rules/no-non-null-asserted-optional-chain.ts 100.00% <ø> (ø)
...s/eslint-plugin/src/rules/no-non-null-assertion.ts 84.37% <ø> (ø)
...ackages/eslint-plugin/src/rules/prefer-as-const.ts 100.00% <ø> (ø)
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 98.07% <ø> (ø)
...s/eslint-plugin/src/rules/prefer-optional-chain.ts 95.23% <ø> (ø)
...nt-plugin/src/rules/switch-exhaustiveness-check.ts 97.67% <ø> (ø)

@G-Rath G-Rath changed the title Add suggestion property Add suggestion property to interface & rules May 17, 2020
@bradzacher bradzacher changed the title Add suggestion property to interface & rules feat(experimental-utils): add suggestion property for rule modules May 17, 2020
@bradzacher bradzacher added the enhancement New feature or request label May 17, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit f42a5b0 into typescript-eslint:master May 17, 2020
@G-Rath G-Rath deleted the add-suggestion-property branch May 17, 2020 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants