Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release note suggests support for TypeScript 3.9 but show warning #2056

Closed
doberkofler opened this issue May 21, 2020 · 3 comments · Fixed by #2057
Closed

Release note suggests support for TypeScript 3.9 but show warning #2056

doberkofler opened this issue May 21, 2020 · 3 comments · Fixed by #2057
Labels
awaiting response Issues waiting for a reply from the OP or another party package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Comments

@doberkofler
Copy link
Contributor

Repro

The release notes for version 3.0.0 suggest multiple times that TypeScript 3.9 is supported but wa warning message is shown.

=============
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <3.8.0

YOUR TYPESCRIPT VERSION: 3.9.3

Please only submit bug reports when using the officially supported version.
=============

Versions

package version
@typescript-eslint/typescript-estree 3.0.0
TypeScript 3.9.3
node 14.3.0
npm 6.14.5
@doberkofler doberkofler added package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for maintainers to take a look labels May 21, 2020
@doberkofler doberkofler changed the title Release notes suggest support for TypeScript 3.9 but show warning Release note suggests support for TypeScript 3.9 but show warning May 21, 2020
@bradzacher
Copy link
Member

bradzacher commented May 21, 2020

See pinned issue #1436

We "support" it in that it won't break, but we don't truly support it yet as we do not have a stable AST for private properties yet.

I've added a note to the release notes pointing at the above issue.

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party and removed triage Waiting for maintainers to take a look labels May 21, 2020
@bradzacher
Copy link
Member

On second thought - #2075 - I'm just going to bump the version range for now.
It's not truly supported, but it won't break so it's supported enough.

We don't want to deter people from upgrading because 3.9 has performance improvements.

@doberkofler
Copy link
Contributor Author

Thank you for caring. Maybe some distinction between supported as in "it will not break" and supported as in "it supports all new features" would be helpful for the future.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants