Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.32.0 & above has a breaking dependency on semver v7, as it doesn't support node 8 #2060

Closed
G-Rath opened this issue May 22, 2020 · 3 comments
Labels
bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Comments

@G-Rath
Copy link
Contributor

G-Rath commented May 22, 2020

If you run yarn upgrade while using Node@8 on eslint-plugin-jest, it will error with the following:

error semver@7.3.2: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.17.0"
error Found incompatible module.

This is because semver was bumped to v7 in #2007 (the PR, not the year 😉)

We're working to get our new major out the door to drop node@8 support, but wanted to upgrade to use #2033.

Versions

package version
@typescript-eslint/typescript-estree 2.32.0
TypeScript 3.9.3
node v8.9.4
npm 6.14.5
yarn 1.22.4
@G-Rath G-Rath added package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for maintainers to take a look labels May 22, 2020
@bradzacher bradzacher added bug Something isn't working and removed triage Waiting for maintainers to take a look labels May 22, 2020
@bradzacher
Copy link
Member

I didn't even notice this because I always run on node v12, and our ci uses --ignore-engines due to some dev deps.

@bradzacher
Copy link
Member

Hmmm.. I don't know how we can action this now. We don't have mechanisms to do out-of-band releases on older versions.

@Borewit
Copy link

Borewit commented May 24, 2020

Caused by: npm/node-semver#327

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Development

No branches or pull requests

3 participants