Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPPORTED_TYPESCRIPT_VERSIONS #2066

Closed
TrejGun opened this issue May 22, 2020 · 3 comments
Closed

SUPPORTED_TYPESCRIPT_VERSIONS #2066

TrejGun opened this issue May 22, 2020 · 3 comments
Labels
package: parser Issues related to @typescript-eslint/parser triage Waiting for maintainers to take a look

Comments

@TrejGun
Copy link

TrejGun commented May 22, 2020

yes I know you hate such types of bugs but still

so here you have

const SUPPORTED_TYPESCRIPT_VERSIONS = '>=3.3.1 <3.10.0';

good range which I like

const SUPPORTED_TYPESCRIPT_VERSIONS = '>=3.3.1 <3.10.0';

but if i do

npm install @typescript-eslint/parser

i see another range which is outdated and i believe was fixed some time ago because in 2.x.x it works fine

test/node_modules/@typescript-eslint/typescript-estree/dist/parser.js

const SUPPORTED_TYPESCRIPT_VERSIONS = '>=3.3.1 <3.8.0';

at the same time package.json in GH and in my local node_module shows same version 3.0.0

@TrejGun TrejGun added package: parser Issues related to @typescript-eslint/parser triage Waiting for maintainers to take a look labels May 22, 2020
@tony
Copy link

tony commented May 22, 2020

Hi! Thank you for this project! Hopefully this information is of assistance.

I believe this issue presents to me like this:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <3.8.0

YOUR TYPESCRIPT VERSION: 3.9.3

Please only submit bug reports when using the officially supported version.

=============

eslint related packages:

    "@typescript-eslint/eslint-plugin": "^3.0.0",                                                                                                                                                                                                
    "@typescript-eslint/parser": "^3.0.0",                                                                                                                                                                                                       
    "eslint-config-prettier": "^6.11.0",                                                                                                                                                                                                         
    "eslint-loader": "^4.0.2",                                                                                                                                                                                                                   
    "eslint-plugin-prettier": "^3.1.3",
    "eslint-plugin-react": "^7.20.0",
    "gatsby-plugin-eslint": "^2.0.8",

Began happening after this upgrade:

diff --git a/package.json b/package.json
index e8bb660..d336448 100644
--- a/package.json
+++ b/package.json
@@ -12,7 +12,7 @@
     "@mdx-js/react": "^1.6.4",
     "emotion-theming": "^10.0.27",
     "flexsearch": "^0.6.32",
-    "gatsby": "^2.22.4",
+    "gatsby": "^2.22.6",
     "gatsby-image": "^2.4.5",
     "gatsby-plugin-catch-links": "^2.3.2",
     "gatsby-plugin-chakra-ui": "^0.1.4",
@@ -45,12 +45,12 @@
   },
   "devDependencies": {
     "@types/moment-duration-format": "^2.2.2",
-    "@types/node": "^14.0.4",
+    "@types/node": "^14.0.5",
     "@types/react": "^16.9.35",
     "@types/react-dom": "^16.9.8",
     "@types/react-helmet": "^6.0.0",
-    "@typescript-eslint/eslint-plugin": "^2.34.0",
-    "@typescript-eslint/parser": "^2.34.0",
+    "@typescript-eslint/eslint-plugin": "^3.0.0",
+    "@typescript-eslint/parser": "^3.0.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-loader": "^4.0.2",
     "eslint-plugin-prettier": "^3.1.3",

@photonstorm
Copy link

Just adding to this issue. Upgrading to 3.0.0 breaks VSCode integration. Likely, because of the error above (unsupported version), but VSCode doesn't know that, so you just get hundreds of lint errors instead, for code that worked fine yesterday. Running eslint on the command-line shows the SUPPORTED warning, which explains why VSCode is failing, but it isn't obvious from the IDE itself.

Downgrading to 2.34 fixes it, so I'll stay at that release for now.

@bradzacher
Copy link
Member

bradzacher commented May 22, 2020

The reason it isn't working with the release, but is correct in master is because it's been fixed in master. See #2057

This will be released on monday morning as part of our standard release cycle.

You can also consider using our canary tag, which is automatically released for every commit to master (i.e. includes the above change).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: parser Issues related to @typescript-eslint/parser triage Waiting for maintainers to take a look
Projects
None yet
Development

No branches or pull requests

4 participants