Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint 7.1.0 no-loss-of-precision: false positives for values with numeric separators #2076

Closed
merlinnot opened this issue May 23, 2020 · 1 comment · Fixed by #2196
Closed

ESLint 7.1.0 no-loss-of-precision: false positives for values with numeric separators #2076

merlinnot opened this issue May 23, 2020 · 1 comment · Fixed by #2196
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@merlinnot
Copy link

I originally created an issue against eslint/eslint, but I was told it might be an issue with @typescript-eslint/parser, so I'm cross-posting here. Original issue contains a detailed description: eslint/eslint#13346. I'd like to understand where the responsibility lies.

Repro

See original issue.

Expected Result

See original issue.

Actual Result

See original issue.

Additional Info

Versions

package version
@typescript-eslint/parser 3.00
TypeScript 3.9.3
ESLint 7.1.0
node 14.0.0
npm 6.14.4
@merlinnot merlinnot added package: parser Issues related to @typescript-eslint/parser triage Waiting for maintainers to take a look labels May 23, 2020
@bradzacher bradzacher added enhancement: new base rule extension New base rule extension required to handle a TS specific case and removed triage Waiting for maintainers to take a look labels May 23, 2020
@bradzacher
Copy link
Member

not a parser issue - the rule doesn't understand that raw can contain underscores.
this will require a base rule extension

@bradzacher bradzacher mentioned this issue May 24, 2020
Closed
@bradzacher bradzacher added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin and removed package: parser Issues related to @typescript-eslint/parser labels May 25, 2020
@yeonjuan yeonjuan mentioned this issue Jun 9, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): add extension rule no-loss-of-precision
2 participants
@bradzacher @merlinnot