fix(eslint-plugin): [unbound-method] fix crash due to missing Intl
#2090
Conversation
When Node.js is compiled with the "--with-intl=none" option ( https://nodejs.org/api/intl.html#intl_options_for_building_node_js ) it will not have the Intl global. As a result, any attempt to run eslint would result in an error like: TypeError: Failed to load plugin '@typescript-eslint' declared in '.eslintrc.js': Cannot convert undefined or null to object Referenced from: /home/dev/web/.eslintrc.js at Function.getOwnPropertyNames (<anonymous>) at /home/dev/web/node_modules/@typescript-eslint/eslint-plugin/dist/rules/unbound-method.js:91:19 We can silently ignore missing globals as a workaround.
|
Thanks for the PR, @eeeee! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
- Coverage 93.45% 93.43% -0.03%
==========================================
Files 171 171
Lines 7747 7749 +2
Branches 2210 2211 +1
==========================================
Hits 7240 7240
- Misses 242 243 +1
- Partials 265 266 +1
|
There was a problem hiding this comment.
I didn't realise it was so common for users to build their own copy of nodejs.
You're like the 5th user to run into this issue (#1944).
I'm okay with this fix.
bradzacher
changed the title
Intl
|
Ah, the fix seemed straightforward so I didn't think of searching closed issues. As for "build their own copy of nodejs", can't speak for the others but I'm doing this because I'm running Gentoo - disabling the "icu" USE flag for the net-libs/nodejs ebuild causes node to be compiled --with-intl=none |
When Node.js is compiled with the "--with-intl=none" option ( https://nodejs.org/api/intl.html#intl_options_for_building_node_js ) it will not have the Intl global. This rule however does expect all SUPPORTED_GLOBALS including Intl to always exist. As a result, any attempt to run eslint would result in an error like:
We can silently ignore missing globals as a workaround.