Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression for eslint v6 #2105

Merged
merged 1 commit into from May 25, 2020
Merged

fix: regression for eslint v6 #2105

merged 1 commit into from May 25, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2100

Includes an integration test against eslint v6 to ensure this doesn't happen again.
Also spent a moment cleaning up the integration tests.

Fixes #2100

Includes an integration test against eslint v6 to ensure this doesn't happen again.
Also spent a moment cleaning up the integration tests.
@bradzacher bradzacher added the bug Something isn't working label May 25, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #2105 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2105      +/-   ##
==========================================
- Coverage   93.44%   93.42%   -0.03%     
==========================================
  Files         171      171              
  Lines        7753     7755       +2     
  Branches     2214     2215       +1     
==========================================
  Hits         7245     7245              
- Misses        243      244       +1     
- Partials      265      266       +1     
Flag Coverage Δ
#unittest 93.42% <0.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...ackages/experimental-utils/src/ts-eslint/ESLint.ts 50.00% <0.00%> (-50.00%) ⬇️

@bradzacher bradzacher merged commit 31fc503 into master May 25, 2020
@bradzacher bradzacher deleted the eslint-v6-regression branch May 25, 2020 20:41
waitingsong added a commit to waitingsong/midway that referenced this pull request May 27, 2020
- eslint
- @typescript-eslint/eslint-plugin
- @typescript-eslint/parser

lerna.json hoist not need @typescript-eslint/*
ref: typescript-eslint/typescript-eslint#2105
waitingsong added a commit to waitingsong/midway that referenced this pull request May 27, 2020
- eslint
- @typescript-eslint/eslint-plugin
- @typescript-eslint/parser

lerna.json hoist not need @typescript-eslint/*
ref: typescript-eslint/typescript-eslint#2105
waitingsong added a commit to waitingsong/midway that referenced this pull request May 27, 2020
- eslint
- @typescript-eslint/eslint-plugin
- @typescript-eslint/parser

lerna.json hoist not need @typescript-eslint/*
ref: typescript-eslint/typescript-eslint#2105
czy88840616 pushed a commit to midwayjs/midway that referenced this pull request May 28, 2020
* chore(devDeps): upgrade for eslint

- eslint
- @typescript-eslint/eslint-plugin
- @typescript-eslint/parser

lerna.json hoist not need @typescript-eslint/*
ref: typescript-eslint/typescript-eslint#2105

* chore(eslint-midway-contrib): remove devDeps typescript
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.0.1] Failed to load parser errors with ESLint v6
1 participant