Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [explicit-module-boundary-types] improve accuracy and coverage #2135

Merged
merged 1 commit into from May 30, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented May 30, 2020

This is a large refactor of the code so that it only checks the functions that should be checked.
Fixes #2134

Also added an option allowArgumentsExplicitlyTypedAsAny in case for some reason users want to allow explicit anys for argument types
Fixes #2119

Finally, this soft removes the shouldTrackReferences option. There's no reason you wouldn't want this set to true, because otherwise there are just a lot of cases it will miss.

This is a large refactor of the code so that it only checks the functions that should be checked.
Fixes #2134

Also added an option `allowArgumentsExplicitlyTypedAsAny`  in case for some reason users want to allow explicit `any`s for argument types
Fixes #2119
@bradzacher bradzacher added bug Something isn't working enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels May 30, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #2135 into master will increase coverage by 0.10%.
The diff coverage is 91.08%.

@@            Coverage Diff             @@
##           master    #2135      +/-   ##
==========================================
+ Coverage   93.42%   93.52%   +0.10%     
==========================================
  Files         171      171              
  Lines        7774     7788      +14     
  Branches     2222     2218       -4     
==========================================
+ Hits         7263     7284      +21     
  Misses        244      244              
+ Partials      267      260       -7     
Flag Coverage Δ
#unittest 93.52% <91.08%> (+0.10%) ⬆️
Impacted Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 89.92% <90.81%> (+7.16%) ⬆️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 98.86% <100.00%> (+0.01%) ⬆️

@bradzacher bradzacher changed the title feat(eslint-plugin): [explicit-module-boundary-types] improve accuracy feat(eslint-plugin): [explicit-module-boundary-types] improve accuracy and coverage May 30, 2020
@bradzacher bradzacher merged commit caaa859 into master May 30, 2020
@bradzacher bradzacher deleted the embt-reduce-false-positives branch May 30, 2020 21:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
1 participant