feat(eslint-plugin): add rule ban-tslint-comment

[drewwyatt]

When migrating from tslint to eslint it's probably somewhat common to have leftover tslint rule flags. This rule aims to help clean those up.

Edit: Apologies for the force-push (I know the CONTRIBUTING guide says to try not to do that). My first commit message was incorrect, hopefully since this wasn't a code change it is okay. 🙏

[typescript-eslint]

Thanks for the PR, @drewwyatt!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #2140 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
+ Coverage   93.44%   93.45%   +0.01%     
==========================================
  Files         171      172       +1     
  Lines        7821     7838      +17     
  Branches     2229     2232       +3     
==========================================
+ Hits         7308     7325      +17     
  Misses        245      245              
  Partials      268      268              

Flag	Coverage Δ
#unittest	93.45% <100.00%> (+0.01%)	⬆️

Impacted Files	Coverage Δ
packages/eslint-plugin/src/configs/all.ts	100.00% <ø> (ø)
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts	100.00% <100.00%> (ø)

[drewwyatt]

Is there anything I can/should do re: codecov failure?

[drewwyatt]

@bradzacher updated. thanks for the feedback!

[drewwyatt]

@bradzacher is there anything this still needs for you to be able to resolve the change request?

[bradzacher]

Nothing you need to do - it's in the review queue.

I usually get around to reviews on the weekend 😄

[bradzacher]

one last question before merge

[bradzacher]

thanks for your work!

[dimitropoulos]

is there any interest in making this a default (well, "recommended") rule in 4.0? if so I can make an issue

[bradzacher]

I'd love to for sure, but many of our users are still transitioning from tslint via our eslint-plugin-tslint, so recommending this rule would cause them a lot of frustration.

[drewwyatt]

@bradzacher @dimitropoulos Could it make sense to recommend as a warning? I get that it can be a lot, but the transition from tslint for our team is what led to wanting to add the rule in the first place.

[bradzacher]

I definitely think this rule has value, and eventually I'd love to add it to recommended.

But right now there are a non-trivial number of users using tslint (~3.2m weekly downloads, compared to our ~5.2m and typescript's ~11.9m), so I think it's too early to be forcing this on users. Ideally I'd be looking for the download counts to be ~10% of the ecosystem before I turn it on.

We'll have to do a 4.0 a lot faster than we did a 3.0 due to #2204, so it definitely won't be in 4.0