New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ban-ts-comment] require comment descriptions by default #2146
Closed
dimitropoulos opened this issue
Jun 1, 2020
· 0 comments
· Fixed by #2330, #2351 or HiroyukiTamura/shirasu#12
Closed
[ban-ts-comment] require comment descriptions by default #2146
dimitropoulos opened this issue
Jun 1, 2020
· 0 comments
· Fixed by #2330, #2351 or HiroyukiTamura/shirasu#12
Labels
breaking change
This change will require a new major version to be released
default rule options
Discussions about default rule options
package: eslint-plugin
Issues related to @typescript-eslint/eslint-plugin
Milestone
Comments
dimitropoulos
added
package: eslint-plugin
Issues related to @typescript-eslint/eslint-plugin
triage
Waiting for maintainers to take a look
labels
Jun 1, 2020
bradzacher
added
breaking change
This change will require a new major version to be released
default rule options
Discussions about default rule options
and removed
triage
Waiting for maintainers to take a look
labels
Jun 1, 2020
bradzacher
added a commit
that referenced
this issue
Aug 3, 2020
…rror` to `allow-with-description` Fixes #2146 BREAKING CHANGE: Default rule options is a breaking change.
This was
linked to
pull requests
Aug 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking change
This change will require a new major version to be released
default rule options
Discussions about default rule options
package: eslint-plugin
Issues related to @typescript-eslint/eslint-plugin
now that #2099 is merged and users can specify
allow-with-description
for the comment directives specified inban-ts-comment
, this issue serves as a reminder to make this change for 4.0.Aside from the tests to be updated, the breaking change will look something like this:
The text was updated successfully, but these errors were encountered: