Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [explicit-module-boundary-types] handle bodyless arrow functions with explicit return types that return functions #2169

Merged
merged 1 commit into from Jun 3, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2161

@bradzacher bradzacher added the bug Something isn't working label Jun 3, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #2169 into master will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
- Coverage   93.47%   93.45%   -0.02%     
==========================================
  Files         171      171              
  Lines        7813     7810       -3     
  Branches     2229     2228       -1     
==========================================
- Hits         7303     7299       -4     
  Misses        244      244              
- Partials      266      267       +1     
Flag Coverage Δ
#unittest 93.45% <40.00%> (-0.02%) ⬇️
Impacted Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 89.14% <0.00%> (-0.09%) ⬇️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts 97.67% <50.00%> (-1.19%) ⬇️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[explicit-module-boundary-types] Complains about inner function expressions in arrow functions
1 participant