Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explicit-member-accessibility] Throws error even though begins with # #2175

Closed
tscpp opened this issue Jun 4, 2020 · 2 comments
Closed
Labels
duplicate This issue or pull request already exists package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@tscpp
Copy link

tscpp commented Jun 4, 2020

Repro

{
  "rules": {
    "@typescript-eslint/explicit-member-accessibility": "error"
  }
}
class MyClass {
  #myPrivateProperty = 'super private';
}

Expected Result
The plugin to not throw an error when the property is marked private with #.

Actual Result
The plugin throws an error even though marked as private with #.

Additional Info
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields

Versions

package version
@typescript-eslint/eslint-plugin 3.0.2
@typescript-eslint/parser 3.0.2
TypeScript 3.9.3
ESLint 7.1.0
node 14.3.0
npm 6.14.4
@tscpp tscpp added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Jun 4, 2020
@bbarry
Copy link
Contributor

bbarry commented Jun 4, 2020

Did you read your console warning?

see #1436

@tscpp
Copy link
Author

tscpp commented Jun 4, 2020

Duplicate #1436

@tscpp tscpp closed this as completed Jun 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2020
@bradzacher bradzacher added duplicate This issue or pull request already exists wontfix This will not be worked on and removed triage Waiting for maintainers to take a look wontfix This will not be worked on labels Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

3 participants