Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [space-before-function-paren] handle abstract functions #2199

Merged
merged 7 commits into from Jul 6, 2020

Conversation

adrielcodeco
Copy link
Contributor

feat(eslint-plugin): [space-before-function-paren] enable rule to abstract function (#2192)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @adrielcodeco!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #2199 into master will decrease coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
- Coverage   93.39%   93.10%   -0.30%     
==========================================
  Files         173      282     +109     
  Lines        7871     9017    +1146     
  Branches     2247     2465     +218     
==========================================
+ Hits         7351     8395    +1044     
- Misses        247      301      +54     
- Partials      273      321      +48     
Flag Coverage Δ
#unittest 93.10% <100.00%> (-0.30%) ⬇️
Impacted Files Coverage Δ
...nt-plugin/src/rules/space-before-function-paren.ts 100.00% <100.00%> (ø)
packages/typescript-estree/src/simple-traverse.ts 75.00% <0.00%> (-20.00%) ⬇️
...-internal/src/rules/no-typescript-estree-import.ts 87.50% <0.00%> (-12.50%) ⬇️
packages/parser/src/scope/scopes.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/configs/all.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/configs/base.ts 100.00% <0.00%> (ø)
packages/parser/src/scope/scope-manager.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-namespace.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/configs/recommended.ts 100.00% <0.00%> (ø)
packages/typescript-estree/src/ts-estree/index.ts 100.00% <0.00%> (ø)
... and 126 more

@adrielcodeco
Copy link
Contributor Author

@bradzacher Who is responsible for adding reviewers?

@bradzacher
Copy link
Member

@bradzacher bradzacher changed the title feat(eslint-plugin): [space-before-function-paren] enable rule to abstract function (#2192) feat(eslint-plugin): [space-before-function-paren] handle abstract functions Jun 19, 2020
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jun 19, 2020
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 22, 2020
@bradzacher bradzacher added bug Something isn't working and removed enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels Jul 6, 2020
@bradzacher bradzacher changed the title feat(eslint-plugin): [space-before-function-paren] handle abstract functions fix(eslint-plugin): [space-before-function-paren] handle abstract functions Jul 6, 2020
@bradzacher bradzacher merged commit 88a3edf into typescript-eslint:master Jul 6, 2020
@bradzacher
Copy link
Member

LGTM - thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants