Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [unbound-method] handling destructuring #2228

Merged
merged 2 commits into from Jun 20, 2020
Merged

fix(eslint-plugin): [unbound-method] handling destructuring #2228

merged 2 commits into from Jun 20, 2020

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Jun 19, 2020

Fixes #2198
Fixes #1112

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #2228 into master will increase coverage by 0.02%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
+ Coverage   93.39%   93.41%   +0.02%     
==========================================
  Files         174      174              
  Lines        7883     7912      +29     
  Branches     2251     2264      +13     
==========================================
+ Hits         7362     7391      +29     
+ Misses        247      246       -1     
- Partials      274      275       +1     
Flag Coverage Δ
#unittest 93.41% <94.11%> (+0.02%) ⬆️
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts 93.82% <94.11%> (+1.51%) ⬆️
packages/eslint-plugin/src/rules/await-thenable.ts 100.00% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-throw-literal.ts 96.07% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 97.31% <0.00%> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts 98.46% <0.00%> (+0.15%) ⬆️
packages/eslint-plugin/src/util/types.ts 82.08% <0.00%> (+0.86%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Jun 19, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on minor nit - otherwise LGTM - thanks for fixing this

packages/eslint-plugin/tests/rules/unbound-method.test.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jun 19, 2020
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 20, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks heaps!

@bradzacher bradzacher merged commit c3753c2 into typescript-eslint:master Jun 20, 2020
@krailler
Copy link

krailler commented Jul 6, 2020

Is this merge published?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
3 participants