feat: split types into their own package #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2229 +/- ##
==========================================
- Coverage 93.46% 93.29% -0.17%
==========================================
Files 174 173 -1
Lines 7953 7788 -165
Branches 2282 2284 +2
==========================================
- Hits 7433 7266 -167
- Misses 246 247 +1
- Partials 274 275 +1
|
bradzacher
force-pushed
the
add-package-types
branch
from
a081449
to
f38ae2e
Compare
As part of the scope analysis work, I want to remove its runtime dependency on `typescript-estree`, so it doesn't need to depend on `typescript`. It only needs a few pieces from the package; AST_NODE_TYPES, and the visitor keys. This moves the following the to a new package, `@typescript-eslint/types`: - `AST_NODE_TYPES` - `AST_TOKEN_TYPES` - `TSESTree` (aka the types for the typescript-estree AST) - `ParserOptions` (moved out of `experimental-utils`) This has the added bonus of getting us very close to removing the need for `parser` to depend on `experimental-utils`, which will reduce its dependency tree significantly.
bradzacher
force-pushed
the
add-package-types
branch
from
f38ae2e
to
dbbb712
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the scope analysis work, I want to remove its runtime dependency on
typescript-estree, so it doesn't need to depend ontypescript.This moves the following to a new package,
@typescript-eslint/types:AST_NODE_TYPESAST_TOKEN_TYPESTSESTree(aka the types for the typescript-estree AST)ParserOptions(moved out ofexperimental-utils)This has the added bonus of getting us very close to removing the need for
parserto depend onexperimental-utils, which will reduce its dependency tree significantly.