Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESTree optional chaining representation #2308

Merged
merged 3 commits into from Jul 28, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Jul 19, 2020

BREAKING CHANGE:
This changes the AST structure to the new ESTree representation for optional chaining.

  • Update types
  • Update visitor-keys
  • Update scope-manager
  • Update typescript-estree
  • Update parser
  • Update experimental-utils
  • Update eslint-plugin
  • Update eslint-plugin-internal

I also ran a quick sanity "integration test" by linking @typescript-eslint/parser into a checkout of the eslint repo to ensure that tests were passing fine there.

Fixes #2204

@bradzacher bradzacher added enhancement New feature or request breaking change This change will require a new major version to be released labels Jul 19, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher changed the title feat: feat: support ESTree optional chaining representation Jul 19, 2020
@bradzacher bradzacher added this to the 4.0.0 milestone Jul 26, 2020
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #2308 into v4 will decrease coverage by 0.04%.
The diff coverage is 89.56%.

@@            Coverage Diff             @@
##               v4    #2308      +/-   ##
==========================================
- Coverage   93.09%   93.05%   -0.05%     
==========================================
  Files         284      285       +1     
  Lines        9097     9109      +12     
  Branches     2499     2503       +4     
==========================================
+ Hits         8469     8476       +7     
- Misses        302      303       +1     
- Partials      326      330       +4     
Flag Coverage Δ
#unittest 93.05% <89.56%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <ø> (ø)
...int-plugin/src/rules/consistent-type-assertions.ts 86.48% <ø> (ø)
...es/eslint-plugin/src/rules/no-array-constructor.ts 100.00% <ø> (ø)
...nt-plugin/src/rules/no-extra-non-null-assertion.ts 100.00% <ø> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 100.00% <ø> (ø)
...ages/eslint-plugin/src/rules/no-require-imports.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/prefer-for-of.ts 90.14% <ø> (ø)
...t-plugin/src/rules/prefer-reduce-type-parameter.ts 100.00% <ø> (ø)
...int-plugin/src/rules/require-array-sort-compare.ts 88.23% <ø> (ø)
... and 24 more

@bradzacher bradzacher marked this pull request as ready for review July 27, 2020 00:56
@bradzacher bradzacher changed the base branch from master to v4 July 27, 2020 14:19
@bradzacher bradzacher merged commit a4bd2a8 into v4 Jul 28, 2020
@bradzacher bradzacher deleted the new-optional-chain branch July 28, 2020 00:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update optional chaining representation to match ESTree spec
1 participant