Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add prefer-enum-initializers rule #2326

Conversation

bobstrange
Copy link
Contributor

Fixes #2268

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bobstrange!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #2326 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2326   +/-   ##
=======================================
  Coverage   93.09%   93.10%           
=======================================
  Files         284      285    +1     
  Lines        9097     9109   +12     
  Branches     2499     2500    +1     
=======================================
+ Hits         8469     8481   +12     
  Misses        302      302           
  Partials      326      326           
Flag Coverage Δ
#unittest 93.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/all.ts 100.00% <ø> (ø)
...slint-plugin/src/rules/prefer-enum-initializers.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Jul 26, 2020
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jul 27, 2020
@bobstrange
Copy link
Contributor Author

@bradzacher

#2326 (comment)

I have fixed suggestions based on your feedback.
Thanks 🙇

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 28, 2020
@bobstrange
Copy link
Contributor Author

@bradzacher

Thank you for your support.
I was wondering if I should really ignore this rule or not :-)
I've fixed that 🙇

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - thanks for your contribution!

@bradzacher bradzacher changed the title feat(eslint-plugin): add prefer-enum-initializers rule feat(eslint-plugin): add prefer-enum-initializers rule Aug 2, 2020
@bradzacher bradzacher merged commit 4f38ea3 into typescript-eslint:master Aug 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Proposal 'prefer-enum-initializers'
2 participants