Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [naming-convention] allow specifying an array of selectors #2335

Merged
merged 15 commits into from Aug 2, 2020
Merged

feat(eslint-plugin): [naming-convention] allow specifying an array of selectors #2335

merged 15 commits into from Aug 2, 2020

Conversation

GavinWu1991
Copy link
Contributor

fixes #2266

GavinWu1991 and others added 12 commits July 11, 2020 18:00
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @GavinWu1991!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jul 28, 2020 •
edited

Codecov Report

Merging #2335 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2335   +/-   ##
=======================================
  Coverage   93.09%   93.10%           
=======================================
  Files         284      284           
  Lines        9097     9102    +5     
  Branches     2499     2500    +1     
=======================================
+ Hits         8469     8474    +5     
  Misses        302      302           
  Partials      326      326
Flag Coverage Δ
#unittest 93.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 89.15% <100.00%> (+0.14%) ⬆️

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Jul 28, 2020
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jul 28, 2020
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jul 30, 2020
bradzacher
bradzacher approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your contribution!

@bradzacher bradzacher changed the title feat(eslint-plugin): [naming-convention] allow specify array of selector feat(eslint-plugin): [naming-convention] allow specifying an array of selectors Aug 2, 2020
@bradzacher bradzacher merged commit 3ef6bd5 into typescript-eslint:master Aug 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[naming-convention] Allow "selector" to specify an array of selectors
2 participants
@GavinWu1991 @bradzacher