Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [ban-ts-comment] change default for ts-expect-error to allow-with-description #2351

Merged
merged 1 commit into from Aug 3, 2020
Merged

feat(eslint-plugin): [ban-ts-comment] change default for ts-expect-error to allow-with-description #2351

merged 1 commit into from Aug 3, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2146

BREAKING CHANGE:

Default rule options is a breaking change.

@bradzacher
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
1e68c46 
…rror` to `allow-with-description`

Fixes #2146

BREAKING CHANGE:

Default rule options is a breaking change.
@bradzacher bradzacher added breaking change This change will require a new major version to be released default rule options Discussions about default rule options labels Aug 3, 2020
@bradzacher bradzacher added this to the 4.0.0 milestone Aug 3, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #2351 into v4 will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v4    #2351      +/-   ##
==========================================
- Coverage   92.97%   92.97%   -0.01%     
==========================================
  Files         285      285              
  Lines        9014     9013       -1     
  Branches     2510     2510              
==========================================
- Hits         8381     8380       -1     
  Misses        304      304              
  Partials      329      329
Flag Coverage Δ
#unittest 92.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts 95.45% <ø> (-0.20%) ⬇️

@bradzacher bradzacher merged commit ef85b7b into v4 Aug 3, 2020
@bradzacher bradzacher deleted the 2146-ban-types-defaults branch August 3, 2020 16:19
@bradzacher bradzacher linked an issue Aug 3, 2020 that may be closed by this pull request
[ban-ts-comment] require comment descriptions by default #2146
Closed
bradzacher added a commit that referenced this pull request Aug 3, 2020
@bradzacher
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
77e7f15 
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 9, 2020
@bradzacher
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
45adae8 
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 10, 2020
@bradzacher
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
c37505d 
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 19, 2020
@bradzacher
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
fbec26b 
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 29, 2020
@bradzacher
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
7081320 
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
bradzacher added a commit that referenced this pull request Aug 29, 2020
@bradzacher
feat(eslint-plugin): [ban-ts-comment] change default for `ts-expect-e…
a3f163a 
…rror` to `allow-with-description` (#2351)

BREAKING CHANGE:

Default rule options is a breaking change.
Fixes #2146
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released default rule options Discussions about default rule options
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

[ban-ts-comment] require comment descriptions by default
1 participant
@bradzacher