Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-throw-literal] support type assertions #2354

Merged
merged 1 commit into from Aug 6, 2020
Merged

fix(eslint-plugin): [no-throw-literal] support type assertions #2354

merged 1 commit into from Aug 6, 2020

Conversation

cherryblossom000
Copy link
Contributor

Fixes #2350

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cherryblossom000!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #2354 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2354   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files         285      285           
  Lines        9125     9125           
  Branches     2504     2504           
=======================================
  Hits         8496     8496           
  Misses        302      302           
  Partials      327      327           
Flag Coverage Δ
#unittest 93.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/eslint-plugin/src/rules/no-throw-literal.ts 96.07% <ø> (ø)

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this!

@bradzacher bradzacher merged commit 470174a into typescript-eslint:master Aug 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-throw-literal] False positive with type assertions
2 participants