fix(typescript-estree): correct ChainExpression interaction with parentheses and non-nulls #2380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some alignment testing against babel and found they handled some things differently. I decided their way was better, so updating the representation to match.
Previously:
TSNonNullExpression
as a breakage in the chain, meaning that theChainExpression
would not move up through them.Now:
TSNonNullExpression
as aChainElement
, so theChainExpression
always moves past them in the tree