Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-condition] fix false positive with nullish coalescing #2385

Merged
merged 1 commit into from Aug 11, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2384

@bradzacher bradzacher added the bug Something isn't working label Aug 11, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #2385 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2385   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files         285      285           
  Lines        9150     9151    +1     
  Branches     2513     2514    +1     
=======================================
+ Hits         8524     8525    +1     
  Misses        301      301           
  Partials      325      325           
Flag Coverage Δ
#unittest 93.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 96.93% <100.00%> (+0.01%) ⬆️

@bradzacher bradzacher merged commit 092c969 into master Aug 11, 2020
@bradzacher bradzacher deleted the 2384 branch August 11, 2020 19:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-condition] False positive with nullish coalescing
1 participant