Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [explicit-module-boundary-types] ignore all bodyless setters #2413

Merged
merged 4 commits into from Aug 21, 2020

Conversation

vansergen
Copy link
Contributor

Related PR #2410

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @vansergen!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #2413 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
- Coverage   93.14%   93.13%   -0.02%     
==========================================
  Files         287      287              
  Lines        9175     9176       +1     
  Branches     2522     2523       +1     
==========================================
  Hits         8546     8546              
  Misses        302      302              
- Partials      327      328       +1     
Flag Coverage Δ
#unittest 93.13% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 87.75% <33.33%> (-0.61%) ⬇️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test you added doesn't fire the code you changed. The function you changed specifically for empty body functions - i.e. function signatures.

I believe that test should instead be something like:

declare class Foo {
  set bar(value: string);
}
export { Foo };

@bradzacher bradzacher added the bug Something isn't working label Aug 21, 2020
@bradzacher bradzacher changed the title fix(eslint-plugin): [explicit-module-boundary-types] ignore setters fix(eslint-plugin): [explicit-module-boundary-types] ignore bodyless setters Aug 21, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher changed the title fix(eslint-plugin): [explicit-module-boundary-types] ignore bodyless setters fix(eslint-plugin): [explicit-module-boundary-types] ignore all bodyless setters Aug 21, 2020
@bradzacher bradzacher merged commit a53f8c6 into typescript-eslint:master Aug 21, 2020
@vansergen vansergen deleted the setters branch August 22, 2020 09:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants