Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint-plugin@4.0.0] need to update peer dependency range? #2444

Closed
AviVahl opened this issue Aug 31, 2020 · 4 comments · Fixed by #2445
Closed

[eslint-plugin@4.0.0] need to update peer dependency range? #2444

AviVahl opened this issue Aug 31, 2020 · 4 comments · Fixed by #2445
Labels
bug Something isn't working dependencies Issue about dependencies of the package package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@AviVahl
Copy link

AviVahl commented Aug 31, 2020

Newly released @typescript-eslint/eslint-plugin has a peerDependency on @typescript-eslint/parser. It currently says:
"@typescript-eslint/parser": "^3.0.0"

Is it compatible with @typescript-eslint/parser@4.0.0?

FYI @bradzacher
@AviVahl AviVahl added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Aug 31, 2020
@bradzacher
Copy link
Member

bradzacher commented Aug 31, 2020 •
edited

fffffffffffffffffffffffffudge.
I forgot that we have this soft dependency range that lerna doesn't auto-update.

@bradzacher bradzacher added bug Something isn't working dependencies Issue about dependencies of the package and removed triage Waiting for maintainers to take a look labels Aug 31, 2020
@AviVahl
Copy link
Author

AviVahl commented Aug 31, 2020

My team has been hit by the same lerna behavior in our projects (basically every time we release a major ;))

bradzacher added a commit that referenced this issue Aug 31, 2020
@bradzacher
fix(eslint-plugin): update parser dependency range
472c1e0 
Fixes #2444

I'm pretty sure we've forgotten do bump this range every single release...
@bradzacher bradzacher mentioned this issue Aug 31, 2020
Merged
bradzacher added a commit that referenced this issue Aug 31, 2020
@bradzacher
fix(eslint-plugin): update parser dependency range (#2445)
2cb6620 
Fixes #2444

I'm pretty sure we've forgotten do bump this range every single release...
@bradzacher
Copy link
Member

I'll try to get an out-of-band release done today.

@bradzacher
Copy link
Member

4.0.1 has been released!

@karrui karrui mentioned this issue Sep 2, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working dependencies Issue about dependencies of the package package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eslint-plugin): update parser dependency range typescript-eslint/typescript-eslint
2 participants
@bradzacher @AviVahl