Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for ESLint v5 #2465

Closed
bradzacher opened this issue Sep 1, 2020 · 1 comment · Fixed by #2683
Closed

Drop support for ESLint v5 #2465

bradzacher opened this issue Sep 1, 2020 · 1 comment · Fixed by #2683
Labels
breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package
Milestone
5.0.0

Comments

@bradzacher
Copy link
Member

Most users have migrated off of v5 by this point, and I think a year back is far enough for us to support.
Supporting old versions restricts which APIs we can use, and makes it harder to build extension rules as we have to take care to fill in missing messageIds ourselves.

ESLint v6.0.0 was released 21 June 2019 - over 1 year ago.
ESLint v5.0.0 was released 22 June 2018 - over 2 years ago. This version predates the official forming of this project.
@bradzacher bradzacher added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint package: parser Issues related to @typescript-eslint/parser package: typescript-estree Issues related to @typescript-eslint/typescript-estree dependencies Issue about dependencies of the package package: utils Issues related to the @typescript-eslint/utils package package: scope-manager Issues related to @typescript-eslint/scope-manager labels Sep 1, 2020
@bradzacher
Copy link
Member Author

We can clean up some of the fallbacks added in #2461

@bradzacher bradzacher removed package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint package: parser Issues related to @typescript-eslint/parser package: scope-manager Issues related to @typescript-eslint/scope-manager package: typescript-estree Issues related to @typescript-eslint/typescript-estree package: utils Issues related to the @typescript-eslint/utils package labels Sep 1, 2020
Merged
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Oct 16, 2020
@bradzacher bradzacher added this to the 5.0.0 milestone Nov 24, 2020
This was referenced Nov 24, 2020
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

chore(eslint-plugin): remove support for eslint 5 thomasmichaelwallace/typescript-eslint
1 participant
@bradzacher