feat(eslint-plugin): [no-shadow] add option ignoreFunctionTypeParameterNameValueShadow
#2470
Conversation
…terNameValueShadow` Fixes #2447 Technically this is backwards incompatible, because I'm adding the option true by default, but I believe that the case it protects against is so rare that it's a substantially better experience this way, and it's what people expect
bradzacher
added
the
enhancement: plugin rule option
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2470 +/- ##
==========================================
- Coverage 92.83% 92.80% -0.04%
==========================================
Files 289 289
Lines 9283 9294 +11
Branches 2594 2599 +5
==========================================
+ Hits 8618 8625 +7
- Misses 320 322 +2
- Partials 345 347 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #2447
Technically this is backwards incompatible, because I'm adding the option true by default, but I believe that the case it protects against is so rare that it's a substantially better experience this way, and it's what people expect