Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add extension rule no-loop-func #2490

Merged
merged 1 commit into from Sep 5, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2448

@bradzacher bradzacher added the enhancement: new base rule extension New base rule extension required to handle a TS specific case label Sep 5, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #2490 into master will increase coverage by 0.02%.
The diff coverage is 96.36%.

@@            Coverage Diff             @@
##           master    #2490      +/-   ##
==========================================
+ Coverage   92.82%   92.84%   +0.02%     
==========================================
  Files         289      290       +1     
  Lines        9294     9349      +55     
  Branches     2600     2620      +20     
==========================================
+ Hits         8627     8680      +53     
  Misses        321      321              
- Partials      346      348       +2     
Flag Coverage Δ
#unittest 92.84% <96.36%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/all.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-loop-func.ts 96.36% <96.36%> (ø)

@bradzacher bradzacher merged commit 36305df into master Sep 5, 2020
@bradzacher bradzacher deleted the 2448-no-loop-func branch September 5, 2020 21:57
@lencioni
Copy link

lencioni commented Sep 9, 2020

Thanks for landing this so quickly!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-loop-func] New false positive in 4.0.0 when using a global type in a function in a loop
2 participants