Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): support rest function type parameters #2491

Merged
merged 1 commit into from Sep 5, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2449

@bradzacher bradzacher added the bug Something isn't working label Sep 5, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #2491 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2491   +/-   ##
=======================================
  Coverage   92.82%   92.82%           
=======================================
  Files         289      289           
  Lines        9294     9299    +5     
  Branches     2600     2602    +2     
=======================================
+ Hits         8627     8632    +5     
  Misses        321      321           
  Partials      346      346           
Flag Coverage Δ
#unittest 92.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts 90.27% <100.00%> (+0.72%) ⬆️

@bradzacher bradzacher merged commit 9d8b4c4 into master Sep 5, 2020
@bradzacher bradzacher deleted the 2449-rest-fn-arg-scope branch September 5, 2020 21:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unused-vars] new v4 false positive: generic type arg used as function parameter list
1 participant