Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): treat type imports as both values and types #2494

Merged
merged 1 commit into from Sep 6, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2453

@bradzacher bradzacher added the bug Something isn't working label Sep 5, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #2494 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2494      +/-   ##
==========================================
- Coverage   92.84%   92.84%   -0.01%     
==========================================
  Files         290      290              
  Lines        9360     9358       -2     
  Branches     2623     2622       -1     
==========================================
- Hits         8690     8688       -2     
  Misses        321      321              
  Partials      349      349              
Flag Coverage Δ
#unittest 92.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-manager/src/definition/ImportBindingDefinition.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher merged commit 916e95a into master Sep 6, 2020
@bradzacher bradzacher deleted the 2453-import-type-value branch September 6, 2020 00:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unused-vars] False positive: type import used in typeof
1 participant