feat(scope-manager): add support for JSX scope analysis #2498
Conversation
Fixes #2455 And part of #2477 JSX is a first-class citizen of TS, so we should really support it as well. I was going to just rely upon `eslint-plugin-react`'s patch lint rules (`react/jsx-uses-react` and `react/jsx-uses-vars`), but that leaves gaps in our tooling. For example #2455, `consistent-type-imports` makes assumptions and can create invalid fixes for react without this change. We could add options to that lint rule for the factory, but that is kind-of a sub-par experience and future rule authors will likely run into similar problems. - Adds full scope analysis support for JSX. - Adds two new `parserOption`: - `jsxPragma` - the name to use for constructing JSX elements. Defaults to `"React"`. Will be auto detected from the tsconfig. - `jsxFragmentName` - the name that unnamed JSX fragments use. Defaults to `null` (i.e. assumes `React.Fragment`). Will be auto detected from the tsconfig.
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2498 +/- ##
==========================================
- Coverage 92.82% 92.80% -0.02%
==========================================
Files 290 290
Lines 9393 9429 +36
Branches 2631 2638 +7
==========================================
+ Hits 8719 8751 +32
- Misses 322 323 +1
- Partials 352 355 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #2455
And some of #2477
JSX is a first-class citizen of TS, so we should really support it as well.
I was going to just rely upon
eslint-plugin-react's patch lint rules (react/jsx-uses-reactandreact/jsx-uses-vars), but that leaves gaps in our tooling.For example #2455,
consistent-type-importsmakes assumptions and can create invalid fixes for react without this change.We could add options to that lint rule for the factory, but that is kind-of a sub-par experience and future rule authors will likely run into similar problems that they'd have to manually build support for.
parserOption:jsxPragma- the name to use for constructing JSX elements. Defaults to"React". Will be auto detected from the tsconfig.jsxFragmentName- the name that unnamed JSX fragments use. Defaults tonull(i.e. assumesReact.Fragment). Will be auto detected from the tsconfig.