Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [dot-notation] add allowProtectedClassPropertyAccess option #2622

Merged
merged 2 commits into from Oct 18, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #2610

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #2622 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2622      +/-   ##
==========================================
- Coverage   92.84%   92.83%   -0.01%     
==========================================
  Files         294      294              
  Lines        9657     9661       +4     
  Branches     2709     2712       +3     
==========================================
+ Hits         8966     8969       +3     
  Misses        326      326              
- Partials      365      366       +1     
Flag Coverage Δ
#unittest 92.83% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/dot-notation.ts 84.21% <ø> (-2.46%) ⬇️

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Oct 1, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezpz - thanks for doing this!

@bradzacher bradzacher changed the title feat(eslint-plugin): [dot-notation] add allowProtectedClassPropertyAccess option feat(eslint-plugin): [dot-notation] add allowProtectedClassPropertyAccess option Oct 18, 2020
@bradzacher bradzacher merged commit bbc9e35 into typescript-eslint:master Oct 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dot-notation] missing option to allow quoted access of protected members
3 participants