fix(eslint-plugin): [ban-types] allow banning types with specific parameters #2662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2657.
The docs for
ban-types
claims thatban-types
can be used with "a type name with generic parameter instantiation(s)", but this functionality never seems to have been implemented. The previous implementation only compared against thetypeName
node of the type reference, but now we also compare against the entireTypeReference
node if there are any type parameters.