Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [naming-convention] check bodyless function parameters #2675

Merged
merged 2 commits into from Oct 18, 2020

Conversation

thomasmichaelwallace
Copy link
Contributor

Resolves #2663

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @thomasmichaelwallace!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@thomasmichaelwallace
Copy link
Contributor Author

thomasmichaelwallace commented Oct 14, 2020

(looking at the other pr's currently open, it looks like codecov is broken)

@bradzacher bradzacher added the bug Something isn't working label Oct 14, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@bradzacher bradzacher changed the title fix(eslint-plugin): [naming-convention] lint class method params fix(eslint-plugin): [naming-convention] check bodyless function parameters Oct 18, 2020
@bradzacher bradzacher merged commit c505863 into typescript-eslint:master Oct 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/naming-convention] Unable to lint declared class method parameters
2 participants