Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-extra-non-null-assertion] false positive with non-nullable computed key #2737

Merged
merged 1 commit into from Nov 5, 2020
Merged

fix(eslint-plugin): [no-extra-non-null-assertion] false positive with non-nullable computed key #2737

merged 1 commit into from Nov 5, 2020

Conversation

ddubrava
Copy link
Contributor

@ddubrava ddubrava commented Nov 4, 2020

Fixes #2732

function foo(key: string | null) {
  const obj = {};
  return obj?.[key!];
}

function foo(key: string | null) {
  const obj = {};
  return obj?.[a!?.key!];
}

function foo(key: string | null) {
  const obj = {};
  return obj!?.[key!];
}

Some extra code tests that were used in AST to check the solution

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ddubrava!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Nov 5, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice and simple 😄 thanks a lot for the contribution!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-extra-non-null-assertion] add TSNonNullExpression.object in selector fix(eslint-plugin): [no-extra-non-null-assertion] false positive with non-nullable computed key Nov 5, 2020
@bradzacher bradzacher merged commit e82698c into typescript-eslint:master Nov 5, 2020
@ddubrava ddubrava deleted the no-extra-non-null-assertion-optional-chaining#2732 branch November 15, 2020 15:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-extra-non-null-assertion] Problems with optional chaining
2 participants