Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unsafe-member-access] ignore MemberExpression's whose parents are either TSClassImplements or TSInterfaceHeritage #2753

Merged
merged 3 commits into from Nov 11, 2020

Conversation

hsmitty93
Copy link
Contributor

Fixes #2740

  • I feel like the selector is too long to be on one line, but it wouldn't work if I split it. Any recommendations to shorten it? Or is it good to go like it is.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @hsmitty93!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Nov 11, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! the idea and tests LGTM.

But I think we can make the selector a little easier on the eyes :)

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Nov 11, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 11, 2020
@bradzacher bradzacher merged commit 535db3b into typescript-eslint:master Nov 11, 2020
@hsmitty93 hsmitty93 deleted the fix-namespace-error branch November 12, 2020 00:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unsafe-member-access] Extending namespaces trigger error
2 participants