feat(typescript-estree): add parseWithNodeMaps
API
#2760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: prettier/prettier#9636
This allows consumers to reach into the underlying TS AST in cases where our AST doesn't quite solve the use case.
Motivating example:
We don't (currently) error for code unless TS itself throws an error.
TS is very permissive, but that leads to some weird (and invalid) code we don't error for, and don't include in the AST.
For example - this is syntactically valid in the TS parser, but they emit a semantic error (we currently ignore semantic errors as they're expensive to calculate)
As it's not a valid place for a decorator - we do not emit its information in the ESTree AST, but as TS treats this as a semantic error - it is parse-time valid.
This creates weird states for consumers wherein they cannot see a decorator exists there, which can cause them to ignore it entirely.
For linting - this isn't a problem. But for something like prettier - this means that they'll delete the decorator at format time!
This is very bad.
Until we implement a solution for #1852 - this will allow consumers to bridge the gap themselves.