fix(typescript-estree): parseWithNodeMaps returning empty maps #2773
Conversation
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
| `); | ||
| const tsNode = result.esTreeNodeToTSNodeMap.get(result.ast.body[0]); | ||
| expect(tsNode).toBeDefined(); | ||
| expect(result.tsNodeToESTreeNodeMap.get(tsNode)).toBeDefined(); |
There was a problem hiding this comment.
Why not
expect(result.tsNodeToESTreeNodeMap.get(tsNode)).toBe(result.ast.body[0]);Isn't it more safer?
There was a problem hiding this comment.
Technically yes - but there are other tests which test the maps (sort of). So it's "good enough" to assert that there's something there.
No description provided.