fix(eslint-plugin): [consistent-type-imports] crash when using both default and namespace in one import

[ota-meshi]

Fixes #2775

[typescript-eslint]

Thanks for the PR, @ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #2778 (b1f2c7a) into master (c2dde58) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2778      +/-   ##
==========================================
+ Coverage   92.80%   92.81%   +0.01%     
==========================================
  Files         300      300              
  Lines        9857     9871      +14     
  Branches     2769     2773       +4     
==========================================
+ Hits         9148     9162      +14     
  Misses        332      332              
  Partials      377      377              

Flag	Coverage Δ
unittest	92.81% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...eslint-plugin/src/rules/consistent-type-imports.ts	97.15% <100.00%> (+0.24%)	⬆️

[bradzacher]

thanks for hopping in to fix this!

[bradzacher]

Hard to notice, but this is being fixed with a double space: import\ \ *.
We probably don't want to be doing that if we can avoid it.

[bradzacher]

I'd consider just dedenting the entire block to 0 (both code and output) so it matches instead of disabling the lint rule

Suggested change

	// eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting
	output: noFormat`
	import type * as Rest from 'module';
	import Default from 'module';
	const a: Rest.A = '';
	`,
	output: noFormat`
	import type * as Rest from 'module';
	import Default from 'module';
	const a: Rest.A = '';
	`,

[bradzacher]

Suggested change

	// eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting
	output: noFormat`
	import type Default from 'module';
	import * as Rest from 'module';
	const a: Default = '';
	`,
	output: noFormat`
	import type Default from 'module';
	import * as Rest from 'module';
	const a: Default = '';
	`,

[bradzacher]

Suggested change

	// eslint-disable-next-line @typescript-eslint/internal/plugin-test-formatting
	output: noFormat`
	import type * as Rest from 'module';
	import type Default from 'module';
	const a: Default = '';
	const b: Rest.A = '';
	`,
	output: noFormat`
	import type * as Rest from 'module';
	import type Default from 'module';
	const a: Default = '';
	const b: Rest.A = '';
	`,

[ota-meshi]

Thank you for checking! I changed this PR.

I didn't know that 0 indentation would eliminate the format error. Thank you for telling me about this. I also fixed some related pre-existing test cases.

[bradzacher]

thanks for working on this!