Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [unbound-method] add support for methods with a this: void parameter #2796

Merged

Conversation

ryota-ka
Copy link
Contributor

Fixes #854

Despite the original issue has the enhancement: plugin rule option label, this looks like just a false positive to me.
Feel free to give feedbacks!

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ryota-ka!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #2796 (c343350) into master (50a46c6) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
- Coverage   92.80%   92.79%   -0.02%     
==========================================
  Files         300      300              
  Lines        9857     9863       +6     
  Branches     2769     2773       +4     
==========================================
+ Hits         9148     9152       +4     
  Misses        332      332              
- Partials      377      379       +2     
Flag Coverage Δ
unittest 92.79% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts 93.10% <75.00%> (-1.96%) ⬇️

@bradzacher bradzacher added bug Something isn't working enhancement: plugin rule option New rule option for an existing eslint-plugin rule and removed bug Something isn't working labels Nov 22, 2020
@bradzacher
Copy link
Member

The reason that I labelled this as an enhancement is because this rule previously does not care about this args.

So adding support for this args is an enhancement to the rule.

@bradzacher bradzacher changed the title fix(eslint-plugin): [unbound-method] false positive when this parameter is typed void feat(eslint-plugin): [unbound-method] add support for methods with a this: void parameter Nov 22, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this!

@bradzacher bradzacher merged commit 878dd4a into typescript-eslint:master Nov 25, 2020
@ryota-ka ryota-ka deleted the unbound-method-this-void branch November 26, 2020 17:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[unbound-method] this annotation should fix error
2 participants