Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [naming-convention] add modifiers exported, global, and destructured #2808

Merged
merged 1 commit into from Nov 24, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2239
Fixes #2512
Fixes #2318
Closes #2802

Adds the following modifiers:

  • exported - matches anything that is exported from the module.
  • global - matches a variable/function declared in the top-level scope.
  • destructured - matches a variable declared via an object destructuring pattern (const {x, z = 2})

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 24, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Base automatically changed from naming-convention-split-property-and-method to master November 24, 2020 19:37
…lobal`, and `destructured`

Fixes #2239
Fixes #2512
Fixes #2318
Closes #2802

Adds the following modifiers:
- `exported` - matches anything that is exported from the module.
- `global` - matches a variable/function declared in the top-level scope.
- `destructured` - matches a variable declared via an object destructuring pattern (`const {x, z = 2}`).
@bradzacher bradzacher force-pushed the naming-convention-exported-global-destructured branch from d6a08d4 to c4cb9f2 Compare November 24, 2020 19:39
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #2808 (c4cb9f2) into master (665b6d4) will decrease coverage by 0.06%.
The diff coverage is 82.08%.

@@            Coverage Diff             @@
##           master    #2808      +/-   ##
==========================================
- Coverage   92.78%   92.71%   -0.07%     
==========================================
  Files         301      301              
  Lines       10159    10191      +32     
  Branches     2870     2889      +19     
==========================================
+ Hits         9426     9449      +23     
  Misses        345      345              
- Partials      388      397       +9     
Flag Coverage Δ
unittest 92.71% <82.08%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 88.43% <82.08%> (-1.39%) ⬇️

@bradzacher bradzacher merged commit fb254a1 into master Nov 24, 2020
@bradzacher bradzacher deleted the naming-convention-exported-global-destructured branch November 24, 2020 19:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
1 participant