Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): fix assertion assignments not being marked as write references #2809

Merged
merged 1 commit into from Nov 24, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2804

@bradzacher bradzacher added the bug Something isn't working label Nov 24, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #2809 (98dae55) into master (665b6d4) will decrease coverage by 0.04%.
The diff coverage is 82.66%.

@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
- Coverage   92.78%   92.74%   -0.05%     
==========================================
  Files         301      301              
  Lines       10159    10196      +37     
  Branches     2870     2890      +20     
==========================================
+ Hits         9426     9456      +30     
+ Misses        345      343       -2     
- Partials      388      397       +9     
Flag Coverage Δ
unittest 92.74% <82.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 88.43% <82.08%> (-1.39%) ⬇️
...ackages/scope-manager/src/referencer/Referencer.ts 94.87% <87.50%> (+0.84%) ⬆️

@bradzacher bradzacher marked this pull request as ready for review November 24, 2020 20:25
@bradzacher bradzacher merged commit fa68492 into master Nov 24, 2020
@bradzacher bradzacher deleted the scope-manager-assertion-assignment branch November 24, 2020 20:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prefer-const] False positives when using non-nullish assertion operator
1 participant