Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [naming-convention] add modifier unused #2810

Merged
merged 1 commit into from Nov 24, 2020

Conversation

bradzacher
Copy link
Member

Fixes #1510

Leverages the infra added in #2768 to mark variables as unused

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 24, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #2810 (87f42b5) into master (fb254a1) will increase coverage by 0.02%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master    #2810      +/-   ##
==========================================
+ Coverage   92.71%   92.74%   +0.02%     
==========================================
  Files         301      301              
  Lines       10191    10232      +41     
  Branches     2889     2902      +13     
==========================================
+ Hits         9449     9490      +41     
+ Misses        345      344       -1     
- Partials      397      398       +1     
Flag Coverage Δ
unittest 92.74% <95.23%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 88.91% <95.23%> (+0.47%) ⬆️
...ackages/scope-manager/src/referencer/Referencer.ts 94.87% <0.00%> (+0.84%) ⬆️

Fixes #1510

Leverages the infra added in #2768 to mark variables as unused
@bradzacher bradzacher merged commit 6a06944 into master Nov 24, 2020
@bradzacher bradzacher deleted the naming-convention-unused branch November 24, 2020 21:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[naming-convention] Allow underscore prefix for unused parameters
1 participant