Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [naming-convention] add requiresQuotes modifier #2813

Merged
merged 1 commit into from Nov 25, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2761
Fixes #1483

This modifier simply matches any member name that requires quotes.
To clarify: this does not match names that have quotes - only names that require quotes.

Fixes #2761
Fixes #1483

This modifier simply matches any member name that requires quotes.
To clarify: this does not match names that have quotes - only names that ***require*** quotes.
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 25, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #2813 (1930e2a) into master (dd0576a) will decrease coverage by 0.02%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master    #2813      +/-   ##
==========================================
- Coverage   92.76%   92.74%   -0.03%     
==========================================
  Files         301      302       +1     
  Lines       10257    10269      +12     
  Branches     2905     2909       +4     
==========================================
+ Hits         9515     9524       +9     
- Misses        344      346       +2     
- Partials      398      399       +1     
Flag Coverage Δ
unittest 92.74% <95.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts 98.00% <ø> (-0.28%) ⬇️
packages/eslint-plugin/src/util/requiresQuoting.ts 90.90% <90.90%> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 89.27% <100.00%> (-0.22%) ⬇️

@bradzacher bradzacher merged commit 6fc8409 into master Nov 25, 2020
@bradzacher bradzacher deleted the naming-convention-quoted-props branch November 25, 2020 06:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
1 participant