Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [naming-convention] allow destructured modifier for parameter selector #2829

Merged
merged 1 commit into from Nov 30, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2828

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 30, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #2829 (5268900) into master (bf904ec) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #2829      +/-   ##
==========================================
- Coverage   92.74%   92.72%   -0.02%     
==========================================
  Files         309      309              
  Lines       10317    10330      +13     
  Branches     2920     2926       +6     
==========================================
+ Hits         9568     9579      +11     
- Misses        346      347       +1     
- Partials      403      404       +1     
Flag Coverage Δ
unittest 92.72% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin/src/rules/naming-convention-utils/schema.ts 93.33% <ø> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 81.18% <57.14%> (+0.28%) ⬆️
...es/eslint-plugin/src/rules/no-use-before-define.ts 91.11% <0.00%> (-1.39%) ⬇️

@bradzacher bradzacher merged commit 525d2ff into master Nov 30, 2020
@bradzacher bradzacher deleted the 2828-nam-conv-param-destructure branch November 30, 2020 00:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[naming-convention] Support destructured modifier for parameters
1 participant